Skip to content

Conversation

@laileni-aws
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Added cwsprChatCodeBlockIndex and cwsprChatTotalCodeBlocks parameters to the onCopyCodeToClipboard and onCodeInsertToCursorPosition events.
  • cwsprChatCodeBlockIndex - Provides the index of that code block, when a user interacts with a code block within a message in the conversation,
  • cwsprChatTotalCodeBlocks - Total number of code blocks inside a generated message.
  • Passed these two parameters to insert_code_at_cursor_position and code_was_copied_to_clipboard telemetry events.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws marked this pull request as ready for review April 16, 2024 15:50
@laileni-aws laileni-aws requested review from a team as code owners April 16, 2024 15:50
"lintfix": "eslint -c .eslintrc.js --fix --ext .ts ."
},
"dependencies": {
"@aws/mynah-ui-chat": "npm:@aws/mynah-ui@4.4.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sync with @dogusata on if this change is safe

#4262

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah @dogusata advised to change version to get the parameter for both Q chat events from mynah-UI.

@laileni-aws laileni-aws changed the base branch from main to feature/cw-proactive-scan April 20, 2024 01:41
@laileni-aws laileni-aws requested a review from rli April 20, 2024 03:54
@laileni-aws laileni-aws requested a review from a team as a code owner April 20, 2024 20:10
@laileni-aws laileni-aws force-pushed the feature/q branch 2 times, most recently from e29c7f9 to a8b3984 Compare April 23, 2024 02:33
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants